Skip to content

1804 add pretrain for densenet senet by using subclass#1812

Merged
wyli merged 11 commits intoProject-MONAI:masterfrom
yiheng-wang-nv:1804-add-pretrain-for-densenet-senet
Mar 22, 2021
Merged

1804 add pretrain for densenet senet by using subclass#1812
wyli merged 11 commits intoProject-MONAI:masterfrom
yiheng-wang-nv:1804-add-pretrain-for-densenet-senet

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Mar 19, 2021

Fixes the new comments in #1804

Status

Work in progress

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor Author

yiheng-wang-nv commented Mar 19, 2021

This PR modifies some updates in #1805

@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review March 20, 2021 10:50
wyli
wyli reviewed Mar 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiheng-wang-nv yiheng-wang-nv mentioned this pull request Mar 22, 2021
Closed
@yiheng-wang-nv
Update docstring
9e751bc 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Copy Markdown
Contributor Author

yiheng-wang-nv commented Mar 22, 2021

Thanks @wyli for the reviews. I modified all places, and the tutorial PR is here

wyli
wyli approved these changes Mar 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) March 22, 2021 06:47
@wyli wyli merged commit b6f213e into Project-MONAI:master Mar 22, 2021
@yiheng-wang-nv yiheng-wang-nv deleted the 1804-add-pretrain-for-densenet-senet branch March 22, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yiheng-wang-nv @wyli