Skip to content

Conditional Random Field#1806

Merged
wyli merged 18 commits intoProject-MONAI:masterfrom
charliebudd:crf-implementation
Mar 25, 2021
Merged

Conditional Random Field#1806
wyli merged 18 commits intoProject-MONAI:masterfrom
charliebudd:crf-implementation

Conversation

@charliebudd
Copy link
Copy Markdown
Collaborator

@charliebudd charliebudd commented Mar 18, 2021 •
edited
Loading

Adds a new feature, Conditional Random Field (CRF). Combines message passing with a class compatability convolution into an iterative process designed to successively minimise the energy of the class labeling.

see #94 and #315

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@charliebudd
conditional random field implementation
e552896 
Signed-off-by: charliebudd <[email protected]>
@charliebudd
fixing variable rename typo
a73028e 
Signed-off-by: charliebudd <[email protected]>
@charliebudd
changing default parameters
01171c0 
Signed-off-by: charliebudd <[email protected]>
@charliebudd
fixing error for non-singular batch size
9d05485 
Signed-off-by: charliebudd <[email protected]>
@charliebudd
unit tests
ed1a47a 
Signed-off-by: charliebudd <[email protected]>
@charliebudd
Removing filter weight normalisation and adding update power factor
3bb1db4 
Signed-off-by: chaliebudd <[email protected]>
@charliebudd
updating unit tests
b03647a 
Signed-off-by: chaliebudd <[email protected]>
@charliebudd
skipping cuda test if no cuda
0ecc530 
Signed-off-by: chaliebudd <[email protected]>
@charliebudd
adding crf to docs
bfde89d 
Signed-off-by: chaliebudd <[email protected]>
@charliebudd charliebudd changed the title Conditional Random Field [WIP] Conditional Random Field Mar 18, 2021
@charliebudd charliebudd changed the title [WIP] Conditional Random Field Conditional Random Field Mar 24, 2021
@charliebudd charliebudd requested a review from wyli March 24, 2021 14:11
@charliebudd charliebudd marked this pull request as ready for review March 24, 2021 14:24
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 24, 2021

/black

thanks I'll run some tests locally and get back to this PR

wyli
wyli reviewed Mar 24, 2021
View reviewed changes
wyli
wyli reviewed Mar 24, 2021
View reviewed changes
wyli
wyli approved these changes Mar 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! cc @SamuelJoutard could you please help review this one? I'll merge it as an initial version, but we'll have follow-up, would be great to get your inputs

@wyli wyli enabled auto-merge (squash) March 24, 2021 22:54
@wyli wyli merged commit b6d1cea into Project-MONAI:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charliebudd @wyli