JIT compiled gaussian mixture model (GMM)#1802
Merged
wyli merged 101 commits intoProject-MONAI:devfrom Jun 20, 2021
Merged
Conversation
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: charliebudd <[email protected]>
Signed-off-by: chaliebudd <[email protected]>
416c5b6 to
b6a6bc4
Compare
Signed-off-by: chaliebudd <[email protected]>
b6a6bc4 to
19bde77
Compare
wyli
reviewed
May 24, 2021
Contributor
wyli
left a comment
There was a problem hiding this comment.
thanks -- I put some comments on the load_module API. now we have the packaging tests, it's time to revisit this PR and merge it soon...
Signed-off-by: chaliebudd <[email protected]>
wyli
reviewed
May 25, 2021
wyli
approved these changes
May 25, 2021
Contributor
wyli
left a comment
There was a problem hiding this comment.
thanks, apart from the minor comments and ci errors, the module looks good to me
Signed-off-by: chaliebudd <[email protected]>
Signed-off-by: chaliebudd <[email protected]>
Contributor
|
/integration-test |
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new feature, gaussian mixture modeling. The algorithm takes some initial labeling and uses a mixture of gaussians to approximate each classes distribution in the feature space. Each unlabled element is then asigned a label based on which classes distibution it fits best.
This is implemented as a c++/cuda extention, but currently it is only implemented in cuda. It may be run with any spatial dimension, channel count, class count, and mixture component count (number of gaussians in each classes mixture).
This PR also introduces JIT compilation for c++/cuda extentions. The source code for this extention is not compiled when monai is installed. When an end user comes to create a GMM python object for the first time, the code will be compiled. This allows us to take parameters passed to the GMM python object and use these as compile time constants in the build allowing the compiler to provide more optimized binaries. A new build is created and stored for each configuration the user asks for. Once a configuration has been built, the JIT system will provide this binary for all subsequent requests.
see #1601
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.