[1798] fix RandZoomd collation#1801
Conversation
Signed-off-by: Richard Brown <[email protected]>
|
@behxyz, do you think you could try this PR? I'm fairly confident it will have solved the problem. |
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
|
@wyli do you understand the error? https://github.com/Project-MONAI/MONAI/pull/1801/checks?check_run_id=2141079751#step:11:5166 It seems that the following code is being executed on the windows and osx test: # skip this test if multiprocessing uses 'spawn', as the check is only basic anyway
if torch.multiprocessing.get_start_method(allow_none=True) == "spawn":
# Check that error is thrown when inverse are used out of order.
t = SpatialPadd("image", [10, 5])
with self.assertRaises(RuntimeError):
t.inverse(forwards[-1]) # <-- windows and osx shouldn't reach here, but they do, causing error |
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
I've changed |
Sure, let me check this PR before merging. |
|
It works perfectly! Thank you, @rijobro, for the quick fix. |
Fixes #1798.
Description
self._zoomwas handled differently depending onself._do_transform. Modified to be the same, such that they can be collated together.Also add testing for all invertible random transforms.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.