Skip to content

Remove WSIReader from LoadImage#1796

Merged
bhashemian merged 4 commits intoProject-MONAI:masterfrom
bhashemian:remove_wsi
Mar 18, 2021
Merged

Remove WSIReader from LoadImage#1796
bhashemian merged 4 commits intoProject-MONAI:masterfrom
bhashemian:remove_wsi

Conversation

@bhashemian
Copy link
Copy Markdown
Member

Description

Since we are not using WSIReader in the same way that we use other image reader, I removed it from LoadImage to avoid any potential issues that it may cause.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian
Copy link
Copy Markdown
Member Author

The problem with the warning message( #1791) will be resolved independent of this PR, so I'm fine if we merge this PR or not.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Mar 18, 2021

Please also update the doc-string of LoadImaged transform.
Others look good to me.

Thanks.

@bhashemian bhashemian enabled auto-merge (squash) March 18, 2021 16:32
@bhashemian bhashemian merged commit 4411758 into Project-MONAI:master Mar 18, 2021
@bhashemian bhashemian deleted the remove_wsi branch March 19, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants