Skip to content

Inverse Zoomd and RandZoomd#1778

Merged
rijobro merged 5 commits intoProject-MONAI:masterfrom
rijobro:inverse_Zoomd
Mar 17, 2021
Merged

Inverse Zoomd and RandZoomd#1778
rijobro merged 5 commits intoProject-MONAI:masterfrom
rijobro:inverse_Zoomd

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Mar 16, 2021

Inverse Zoomd and RandZoomd

#1515

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

rijobro added 2 commits March 16, 2021 11:31
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from Nic-Ma, ericspod and wyli March 16, 2021 11:36
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rijobro rijobro enabled auto-merge (squash) March 17, 2021 09:16
@rijobro rijobro merged commit cf3bd1a into Project-MONAI:master Mar 17, 2021
@rijobro rijobro deleted the inverse_Zoomd branch March 17, 2021 13:34
d = dict(data)
if not self._do_transform:
for key in self.keys:
self.push_transform(d, key, extra_info={"zoom": self._zoom})
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps extra_info self._zoom could have different sizes (on/off _do_transform) in a batch loader, then they are not compatible with the collate #1798

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right. You can see there's a few ensure_tuple(self._zoom) that come a few lines later, so they just need to be moved ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants