Skip to content

Update WSIReader with cuCIM#1773

Merged
bhashemian merged 9 commits intoProject-MONAI:masterfrom
bhashemian:behrooz_cucim
Mar 16, 2021
Merged

Update WSIReader with cuCIM#1773
bhashemian merged 9 commits intoProject-MONAI:masterfrom
bhashemian:behrooz_cucim

Conversation

@bhashemian
Copy link
Copy Markdown
Member

@bhashemian bhashemian commented Mar 16, 2021

Description

The official CuImage package will be released soon on PyPI under the name of cuCIM. This PR update WSIReader to this new naming from cuClaraImage.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian bhashemian requested a review from Nic-Ma March 16, 2021 02:17
@bhashemian bhashemian enabled auto-merge (squash) March 16, 2021 02:18
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Mar 16, 2021

Hi @behxyz ,

As cuCIM is available for public installation, could you please help enable the installation and CI tests?

Thanks.

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Mar 16, 2021

Hi @Nic-Ma, it is not public yet but once it's public, I will take care of that. That'd be the topic of another PR.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Mar 16, 2021

Hi @behxyz ,

May I know when it will public release?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 16, 2021

perhaps the PyPI package's metadata is incomplete? I tried pip install and check the file lib/python3.7/site-packages/cucim-0.0.0.dist-info/METADATA the version is 0.0.0 :

Metadata-Version: 2.1
Name: cucim
Version: 0.0.0
Summary: A GPU Image I/O and Processing Toolkit
Home-page: https://github.com/gigony/cucim
Author: Gigon Bae
Author-email: [email protected]
License: Apache Software License 2.0
Keywords: cucim
Platform: UNKNOWN

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Mar 16, 2021

@Nic-Ma, @wyli
cuCIM is released! Yay! https://pypi.org/project/cucim/0.18.0/
It only supports Linux and according to the developer there is no plan to support Mac or Windows.
I can see that for Windows platform we are only importing the first 12 dependencies so it passes the windows testing as well! However, it is not the case for Mac platform.

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Mar 16, 2021

@Nic-Ma, @wyli
cuCIM is released! Yay! https://pypi.org/project/cucim/0.18.0/
It only supports Linux and according to the developer there is no plan to support Mac or Windows.
I can see that for Windows platform we are only importing the first 12 dependencies so it passes the windows testing as well! However, it is not the case for Mac platform.

I have excluded cucim on MacOS platform for CI/CD.

wyli
wyli approved these changes Mar 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks good to me, could you please confirm @Nic-Ma

@bhashemian bhashemian merged commit bcbd685 into Project-MONAI:master Mar 16, 2021
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 16, 2021

sorry I didn't know there's an auto-merge @Nic-Ma

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Mar 16, 2021

Hi @behxyz and @wyli ,

PR looks good to me.
Thanks for the great work!!

@bhashemian bhashemian deleted the behrooz_cucim branch March 17, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhashemian @Nic-Ma @wyli