Skip to content

include some recent changes of dev tools in the contrib guide#1763

Merged
Nic-Ma merged 4 commits intoProject-MONAI:masterfrom
wyli:revise-contrib-guide
Mar 16, 2021
Merged

include some recent changes of dev tools in the contrib guide#1763
Nic-Ma merged 4 commits intoProject-MONAI:masterfrom
wyli:revise-contrib-guide

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Mar 14, 2021

Signed-off-by: Wenqi Li [email protected]

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, ericspod and rijobro March 14, 2021 15:19
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Mar 15, 2021

Hi @rijobro ,

Could you please help take a look at this random CI error of spatial inverse transform?

Thanks.

@rijobro
Copy link
Copy Markdown
Contributor

rijobro commented Mar 15, 2021

Hi @Nic-Ma, as I said in this comment, I don't fully understand why the error wasn't present in the original PR and now is suddenly happening. I'll reduce the amount of the image that is cropped, which should hopefully solve the problem, but I'm slightly lost as to why it's happening.

@Nic-Ma Nic-Ma merged commit 3ea9ed4 into Project-MONAI:master Mar 16, 2021
@wyli wyli deleted the revise-contrib-guide branch March 16, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants