Description

It seems like 0bd86b1 (67b2b1d) introduces changes which don't pass the pytype check running ./runtests.sh -f -u --net --coverage. It's not clear to me why removing the cast in that commit should do this since the .int() should still return a torch.Tensor? But these changes make it so that pytype passes. Alternatively could do

return torch.Tensor((logits >= threshold).int())

in the function but not sure what the original commit was trying to do by removing the cast.

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.