1742 Add DistributedWeightedRandomSampler#1745
Merged
wyli merged 18 commits intoProject-MONAI:masterfrom Mar 12, 2021
Merged
Conversation
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
ericspod
reviewed
Mar 11, 2021
ericspod
reviewed
Mar 11, 2021
ericspod
reviewed
Mar 11, 2021
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
Hi @ericspod , Thanks for your review. Thanks. |
Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
force-pushed
the
1742-add-distributed-weighted-random-sampler
branch
from
8b5cd42 to
74883b1
Compare
ericspod
reviewed
Mar 11, 2021
ericspod
requested changes
Mar 11, 2021
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
I think it's worth the effort to clean up the arguments in the constructor still but otherwise it looks good.
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
force-pushed
the
1742-add-distributed-weighted-random-sampler
branch
from
e24d397 to
2537956
Compare
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
1 similar comment
Contributor
Author
|
/black |
Contributor
Author
|
Hi @ericspod , Thanks for your review. Thanks. |
wyli
previously approved these changes
Mar 11, 2021
Contributor
Author
wyli
approved these changes
Mar 12, 2021
Contributor
|
I rerun the tests a few times, works fine now, could you help review it again? @ericspod |
ericspod
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1742 .
Description
This PR added the
DistributedWeightedRandomSamplerto enhance MONAI samplers.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.