Fix MONAI docker dependency#1731
Merged
wyli merged 2 commits intoProject-MONAI:masterfrom Mar 9, 2021
Merged
Conversation
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Member
Author
|
I have tested the MONAI docker locally as well as the steps that I added to cron for nightly tests. Do you know any other way to test the GitHub cron action apart from merging and checking on that later? |
Contributor
thanks! I also tested your changes locally, all worked fine. we don't often update the self-hosted ci/cd pipelines, but if needed we create branches within the repo (instead of a fork) and change the triggering events temporarily for testing purposes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1721
Description
Update MONAI docker and nightly tests docker (
cron-pt-image) to include OpenSlide library dependenciesStatus
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.