Skip to content

remove printing msg#1730

Merged
ericspod merged 2 commits intoProject-MONAI:masterfrom
wyli:remove-print-reader
Mar 9, 2021
Merged

remove printing msg#1730
ericspod merged 2 commits intoProject-MONAI:masterfrom
wyli:remove-print-reader

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Mar 9, 2021

Signed-off-by: Wenqi Li [email protected]

Description

removes the debugging info from WSIreader, to be consistent with the other readers

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro March 9, 2021 17:46
@ericspod ericspod enabled auto-merge (squash) March 9, 2021 17:47
Signed-off-by: Wenqi Li <[email protected]>
@ericspod ericspod merged commit ea1d04b into Project-MONAI:master Mar 9, 2021
@bhashemian
Copy link
Copy Markdown
Member

@wyli, it was more of a user info than a debugging info. Unlike the other readers, this reader uses different libraries so it might be useful to inform the user which one is being used.

@wyli wyli deleted the remove-print-reader branch March 9, 2021 21:51
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Mar 9, 2021

@behxyz I was trying to load a nifti file using the loadimaged API, it printed 'openslide is being used' which is quite confusing

@bhashemian
Copy link
Copy Markdown
Member

@wyli,
oh you are right! that's very confusing and shouldn't happen. It is because WSIReader is being instantiated in LoadImage, which I think we should change at some point, but at the meantime I'll add the info somewhere deeper into the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants