Skip to content

Update DataLoader arg type of workflow#1719

Merged
wyli merged 9 commits intoProject-MONAI:masterfrom
Nic-Ma:update-workflow-arg-type
Mar 9, 2021
Merged

Update DataLoader arg type of workflow#1719
wyli merged 9 commits intoProject-MONAI:masterfrom
Nic-Ma:update-workflow-arg-type

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Mar 8, 2021

Partly fixes #1707 .

Description

This PR updated the arg type of DataLoader to be consistent with ignite.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 8, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 8, 2021 15:44
monai-bot and others added 2 commits March 8, 2021 15:46
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 9, 2021

Hi @wyli @rijobro @ericspod ,

This PR updated the data_loader arg type to Union[Iterable, DataLoader] referring to ignite:
https://github.com/pytorch/ignite/blob/master/ignite/engine/engine.py#L568

Thanks.

@Nic-Ma Nic-Ma force-pushed the update-workflow-arg-type branch from 2c316da to 76bf07e Compare March 9, 2021 02:04
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 9, 2021

/black

@wyli wyli enabled auto-merge (squash) March 9, 2021 12:16
@wyli wyli merged commit 0751ca0 into Project-MONAI:master Mar 9, 2021
@Nic-Ma Nic-Ma deleted the update-workflow-arg-type branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MONAI Workflow incompatible with ThreadBuffer

4 participants