Skip to content

1708 update args in datasets#1712

Merged
wyli merged 6 commits intoProject-MONAI:masterfrom
Nic-Ma:1708-update-args-datasets
Mar 8, 2021
Merged

1708 update args in datasets#1712
wyli merged 6 commits intoProject-MONAI:masterfrom
Nic-Ma:1708-update-args-datasets

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Mar 8, 2021

Fixes #1708 .

Description

This PR updated the args in several datasets to be consistent with the latest design.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 8, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 8, 2021 08:53
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 8, 2021

I tested num_init_workers=None and num_replace_worker=None in SmartCacheDataset with our distributed training example: https://github.com/Project-MONAI/tutorials/blob/master/acceleration/distributed_training/unet_training_smartcache.py

Thanks.

@wyli wyli enabled auto-merge (squash) March 8, 2021 09:15
@wyli wyli merged commit 634b32d into Project-MONAI:master Mar 8, 2021
@Nic-Ma Nic-Ma deleted the 1708-update-args-datasets branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update args of Datasets

2 participants

@Nic-Ma @wyli