Skip to content

Update load pretrain for densenet#1684

Merged
wyli merged 4 commits intoProject-MONAI:masterfrom
yiheng-wang-nv:1681-fix-densenet-pretrain
Mar 3, 2021
Merged

Update load pretrain for densenet#1684
wyli merged 4 commits intoProject-MONAI:masterfrom
yiheng-wang-nv:1681-fix-densenet-pretrain

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

Signed-off-by: Yiheng Wang [email protected]

Fixes #1681 .

Description

Except for the re-implementation of load pre-trained weights function, a new test case is added. For the same input tensor, the output between the torchvision's densenet and our version should be the same.

Status

Ready/Work in progress/Hold

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review March 3, 2021 15:41
@yiheng-wang-nv yiheng-wang-nv requested review from Nic-Ma and wyli March 3, 2021 15:42
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 3, 2021

/integration-test

@wyli wyli merged commit 4bd9cf3 into Project-MONAI:master Mar 3, 2021
@yiheng-wang-nv yiheng-wang-nv deleted the 1681-fix-densenet-pretrain branch March 4, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Densenet pretrained weights issue

2 participants