Skip to content

1500-update grid dataset to support patch level transforms#1679

Merged
wyli merged 7 commits intoProject-MONAI:masterfrom
wyli:1500-gridpatchdataset-transform-support
Mar 8, 2021
Merged

1500-update grid dataset to support patch level transforms#1679
wyli merged 7 commits intoProject-MONAI:masterfrom
wyli:1500-gridpatchdataset-transform-support

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Mar 3, 2021

Signed-off-by: Wenqi Li [email protected]

Fixes #1500

Description

revised grid patch dataset to support patch level transforms and coordinates outputs.

Status

Ready

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli force-pushed the 1500-gridpatchdataset-transform-support branch from fa49827 to 50e42ae Compare March 3, 2021 01:08
@wyli wyli marked this pull request as draft March 3, 2021 01:28
@wyli wyli force-pushed the 1500-gridpatchdataset-transform-support branch 3 times, most recently from cbcf755 to f250f78 Compare March 3, 2021 14:58
@wyli wyli requested review from Nic-Ma, ericspod and rijobro and removed request for ericspod and rijobro March 3, 2021 15:26
@wyli wyli marked this pull request as ready for review March 3, 2021 15:26
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Mar 4, 2021

/black

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement.
Looks good to me.
@ericspod do you have any more comments?

Thanks.

@wyli wyli force-pushed the 1500-gridpatchdataset-transform-support branch 4 times, most recently from 60e2121 to b27d9ff Compare March 8, 2021 16:02
@wyli wyli force-pushed the 1500-gridpatchdataset-transform-support branch from b27d9ff to 0726863 Compare March 8, 2021 16:02
@wyli wyli enabled auto-merge (squash) March 8, 2021 16:35
@wyli wyli merged commit cbddce9 into Project-MONAI:master Mar 8, 2021
@wyli wyli deleted the 1500-gridpatchdataset-transform-support branch March 8, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GridPatchDataset to support patch level transformations

3 participants