1633 fix string length > 1024 issue in all_gather#1634
Merged
wyli merged 13 commits intoProject-MONAI:masterfrom Feb 25, 2021
Merged
1633 fix string length > 1024 issue in all_gather#1634wyli merged 13 commits intoProject-MONAI:masterfrom
wyli merged 13 commits intoProject-MONAI:masterfrom
Conversation
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <[email protected]>
wyli
reviewed
Feb 24, 2021
yiheng-wang-nv
approved these changes
Feb 25, 2021
Contributor
yiheng-wang-nv
left a comment
yiheng-wang-nv
left a comment
There was a problem hiding this comment.
Thanks Nic, I did some test locally and it works fine.
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
Hi @wyli , The CI failed due to some CUDA driver missing issue, have you seen this before? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1633 .
Description
This PR fixed the string list all gather issue when length > 2014. Changed to all_gather every item separately instead of joining to a long string.
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.