Revert "1568 Enhance tests to use self random state (#1599)"#1607
Merged
Nic-Ma merged 1 commit intoProject-MONAI:masterfrom Feb 21, 2021
Merged
Revert "1568 Enhance tests to use self random state (#1599)"#1607Nic-Ma merged 1 commit intoProject-MONAI:masterfrom
Nic-Ma merged 1 commit intoProject-MONAI:masterfrom
Conversation
…)" This reverts commit 181f633. Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
i'm not 100% sure if this is related to #1599 but it was more stable before this. please look into it if you have time https://github.com/Project-MONAI/MONAI/runs/1947486945?check_suite_focus=true#step:6:8667 @Nic-Ma |
Contributor
|
I think maybe we should set a different random seed for every test case, so every test will be deterministic. Thanks. |
Nic-Ma
approved these changes
Feb 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 181f633.
Signed-off-by: Wenqi Li [email protected]
fixes #1599
Description
#1599 still generates nondeterministic results
Status
Ready
Types of changes