1567 add RemoveRepeatedChannel#1569
Conversation
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam <[email protected]>
|
thanks, adding the new class to this file will address some of the ci/cd errors https://github.com/Project-MONAI/MONAI/blob/master/monai/transforms/__init__.py#L258 |
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam <[email protected]>
|
I find the name slightly confusing. I would expect Alternatively, an |
|
That's probably clearer to fit the use case. As for adding the inverse method to your spatial transforms PR, the hesitation would be it bloats the scope of that PR as it's a nontrivial expansion of scope, and makes it harder to test. Discussing tests, what's this windows-latest CPU test failing? There's no clear error message. @wyli any helpful comments for these two items? |
|
I think the relevant part of the Windows error is here. It's trying to use pretrained |
|
agree that this transforms is removing channels according to the 'repeated' pattern, I think RemoveRepeatedChannel is more appropriate... |
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam <[email protected]>
Signed-off-by: Leo Tam [email protected]
Fixes #1567 .
Description
Add DeleteChannel inverse operation to RepeatChannel via slicing. I tried squashing the commits which hilarious duplicated them instead. Anyways if it passes review, can fight git more.
Status
Work in progress
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.