Skip to content

1556 Enhance doc-strings of Rotate90 and Flip transforms#1562

Merged
wyli merged 4 commits intoProject-MONAI:masterfrom
Nic-Ma:1556-simplify-redundent-trans
Feb 8, 2021
Merged

1556 Enhance doc-strings of Rotate90 and Flip transforms#1562
wyli merged 4 commits intoProject-MONAI:masterfrom
Nic-Ma:1556-simplify-redundent-trans

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Feb 8, 2021

Fixes #1556 .

Description

This PR enhanced the doc-strings and unit-tests to make the spatial_axes arg more clear to use.
It can be None(for all spatial axes), negative numbers, positive numbers.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Feb 8, 2021

/black

@wyli wyli merged commit aab702a into Project-MONAI:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random flip per channel seems redundant

3 participants