Skip to content

Enhance Rotate90 transform with more check#1432

Merged
wyli merged 4 commits intoProject-MONAI:masterfrom
Nic-Ma:enhance-rotate90-check
Jan 12, 2021
Merged

Enhance Rotate90 transform with more check#1432
wyli merged 4 commits intoProject-MONAI:masterfrom
Nic-Ma:enhance-rotate90-check

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jan 12, 2021

Description

According to our internal team's feedback from Dong Yang, this PR added a converter to convert the spatial_axes arg to tuple and check the length.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 12, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jan 12, 2021

/black

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 50bcaf1 into Project-MONAI:master Jan 12, 2021
@Nic-Ma Nic-Ma deleted the enhance-rotate90-check branch July 2, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants