Merged
Conversation
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
wyli
reviewed
Jan 11, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks -- some minor comments in line
|
|
||
| def __call__( # type: ignore | ||
| self, x: torch.Tensor, class_idx: Optional[Union[int, torch.Tensor]] = None, b_box: Optional[Sequence] = None | ||
| self, |
Contributor
There was a problem hiding this comment.
I thought with non-empty class_idx option it'll save some memory here?
Contributor
Author
There was a problem hiding this comment.
There's a marginal increase in memory, the output image might be e.g., 64,64,64,3 instead of 64,64,64 for 3D and even smaller for 2D. Since batch size is always 1, the images will always be small, and it seems a shame to discard the information when it's generated anyway during the inference step at no extra cost.
wyli
reviewed
Jan 11, 2021
wyli
reviewed
Jan 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last update to occlusion sensitivity.
Description
@wyli this finally behaves as I expect and I'll upload the tutorials to match.
Now you can:
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.