Improve docker build process#1419
Merged
wyli merged 2 commits intoProject-MONAI:masterfrom Jan 7, 2021
IsaacYangSLA:update_dockerfile
Merged
Improve docker build process#1419wyli merged 2 commits intoProject-MONAI:masterfrom IsaacYangSLA:update_dockerfile
wyli merged 2 commits intoProject-MONAI:masterfrom
IsaacYangSLA:update_dockerfile
Conversation
wyli
reviewed
Jan 7, 2021
COPY only needed Fix LICENSE Verify the tests in docker still works Add MAINFEST.in, .gitignore and .gitattributes Signed-off-by: Isaac Yang <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
approved these changes
Jan 7, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, dockerfile is tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COPY only needed
Fix LICENSE
Verify the tests in docker still works
Signed-off-by: Isaac Yang [email protected]
Fixes # .
Description
Added .dockerignore to filter out unnecessary files/folder from the docker build context
Specified files/folders to be added into docker images, instead of all files/folders in current folder.
May still need to figure out which should 'exactly' be included in the release container images. Developers may love to have tests and docs, but not for runtime users.
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.