Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Member
|
The issue with the comment breaking up a multiline shell command is probably common, I've done it myself. Is there a reason to chain commands together with && rather than have multiple RUN commands? If we had multiple command we can comment them safely, but I assume using && is a common Docker pattern for some reason. |
Contributor
Author
|
yeah I think it minimises the number of layers and size of the image @ericspod |
Member
|
A possible solution to interspersed comments isn't exactly pretty. |
Nic-Ma
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes docker build error https://github.com/Project-MONAI/MONAI/runs/1658975018#step:3:2335
Status
Ready
Types of changes