Skip to content

1405 add bending energy loss#1408

Merged
wyli merged 14 commits intoProject-MONAI:masterfrom
kate-sann5100:1405-bending-energy
Jan 6, 2021
Merged

1405 add bending energy loss#1408
wyli merged 14 commits intoProject-MONAI:masterfrom
kate-sann5100:1405-bending-energy

Conversation

@kate-sann5100
Copy link
Copy Markdown
Collaborator

@kate-sann5100 kate-sann5100 commented Jan 5, 2021 •
edited
Loading

Fixes #1408 .

Description

Add bending energy loss useful for registration.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@kate-sann5100
1405 add bending energy loss
34fb746 
Signed-off-by: kate-sann5100 <[email protected]>
@kate-sann5100
1405 update documentation
5fb43b6 
Signed-off-by: kate-sann5100 <[email protected]>
@kate-sann5100 kate-sann5100 changed the title 1405 add bending energy loss [WIP] [WIP]1405 add bending energy loss Jan 5, 2021
@kate-sann5100
1405 fix integer divison
5386871 
Signed-off-by: kate-sann5100 <[email protected]>
@kate-sann5100
1405 fix integer division
c532517 
Signed-off-by: kate-sann5100 <[email protected]>
@kate-sann5100 kate-sann5100 changed the title [WIP]1405 add bending energy loss 1405 add bending energy loss Jan 6, 2021
wyli
wyli reviewed Jan 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, the style/format of this PR looks great, it's a really nice starting point. I put some comments about the actual logic. ideally we should have something general for different spatial dimensions, not just for spatial 3D

wyli
wyli approved these changes Jan 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I forgot to mention that perhaps rename gradient to spatial_gradient to avoid confusion?

also, do you want to put some acknowledgement in the docstring such asadapted from DeepRegNet? cc @YipengHu

@YipengHu
Copy link
Copy Markdown

YipengHu commented Jan 6, 2021

thanks, I forgot to mention that perhaps rename gradient to spatial_gradient to avoid confusion?

also, do you want to put some acknowledgement in the docstring such asadapted from DeepRegNet? cc @YipengHu

Sounds good to have a reference to DeepReg, using either the paper or github URL.
"spatial_gradient" is more specific and better.

@wyli wyli merged commit 5aa5e16 into Project-MONAI:master Jan 6, 2021
@wyli wyli mentioned this pull request Feb 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YipengHu YipengHu YipengHu left review comments

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kate-sann5100 @YipengHu @wyli