Fix failures from many pulls from hub.docker.com (Done)#1406
Merged
wyli merged 20 commits intoProject-MONAI:masterfrom Jan 6, 2021
Merged
Fix failures from many pulls from hub.docker.com (Done)#1406wyli merged 20 commits intoProject-MONAI:masterfrom
wyli merged 20 commits intoProject-MONAI:masterfrom
Conversation
Signed-off-by: Daniel Schulz [email protected] <[email protected]>
added list of Nvidia maintainers resolves: "docker image tests failed due to dockerhub limitation Project-MONAI#1380" Signed-off-by: Daniel Schulz [email protected] <[email protected]>
danielschulz
changed the title
Contributor
|
thanks, this also addresses #1276 cc @IsaacYangSLA |
wyli
reviewed
Jan 5, 2021
Signed-off-by: Daniel Schulz [email protected] <[email protected]>
Signed-off-by: Daniel Schulz [email protected] <[email protected]>
Signed-off-by: Daniel Schulz [email protected] <[email protected]>
…nt rate limiting on it remark: do not use it as pull-through cache as this would not work with static labels and docker images would diverge from one another Signed-off-by: Daniel Schulz [email protected] <[email protected]>
Signed-off-by: Daniel Schulz [email protected] <[email protected]>
Signed-off-by: Daniel Schulz [email protected] <[email protected]>
Signed-off-by: Daniel Schulz [email protected] <[email protected]>
Signed-off-by: Daniel Schulz [email protected] <[email protected]>
Contributor
Author
|
That's basically it. I'd appreciate you comment on what might be left to do or revise. Thank you. I am not sure, whether I am able to test all GitHub Actions from my fork. May I just remove the date changes to "2020 - 2021" again or may I leave it in my PR? Thanks for getting back to me. |
danielschulz
changed the title
wyli
reviewed
Jan 6, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, it looks great, I just have a minor comment about the meta data
got rid of "as base" extension in FROM -- seems not be be pickup downwards (is no multi-stage Docker build -- hence: removed) Signed-off-by: Daniel Schulz [email protected] <[email protected]>
danielschulz
commented
Jan 6, 2021
Contributor
Author
danielschulz
left a comment
danielschulz
left a comment
There was a problem hiding this comment.
thanks, it looks great, I just have a minor comment about the meta data
I changed it accordingly...
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
You're welcome. It was a pleasure to contribute my bit. PS: Also your products are great! I am using your GPUs professionally and personally for years now. Really great work from Nvidia! Thank you for this. |
danielschulz
changed the title
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
1380-dockerhub-rate-limit
branch
from
0898026 to
1dc66bd
Compare
Contributor
Author
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1380 .
Description
As Docker Hub is applying a rate limit for unauthorized pulls, we need to check how to pull images from it less often. Else, there will be regular failures in the CI pipeline just for technical reasons.
Status
Work in progress
Types of changes