Skip to content

1390 Enhance DynUNet with get_feature_maps API#1393

Merged
wyli merged 4 commits intoProject-MONAI:masterfrom
Nic-Ma:1390-enhance-dyunet-feature-map
Dec 30, 2020
Merged

1390 Enhance DynUNet with get_feature_maps API#1393
wyli merged 4 commits intoProject-MONAI:masterfrom
Nic-Ma:1390-enhance-dyunet-feature-map

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Dec 23, 2020 •
edited by wyli
Loading

Fixes #1390 .

Description

As more than 3 users reported the problem with DynUNet, we need to change the return data of forward function.
This PR added get_feature_maps API according to @rijobro 's suggestion in #1263 (comment).

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Dec 23, 2020 •
edited by wyli
Loading

/black

wyli
wyli reviewed Dec 30, 2020
View reviewed changes
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Dec 30, 2020

/black

wyli
wyli approved these changes Dec 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a breaking change, may need to update the tutorial as well

@wyli wyli merged commit e2c0ed2 into Project-MONAI:master Dec 30, 2020
@rijobro rijobro mentioned this pull request Jan 13, 2021
Closed
@rijobro rijobro mentioned this pull request Feb 8, 2021
Closed
@DrAlaafeef
Copy link
Copy Markdown

DrAlaafeef commented Feb 21, 2021

I got an error when trying to run the DynUNet tutorial using the docker image "projectmonai/monai:latest" on 21/2/2021.

"torch.nn.modules.module.ModuleAttributeError: 'DynUNet' object has no attribute 'get_feature_maps'"

@rijobro
Copy link
Copy Markdown
Contributor

rijobro commented Feb 21, 2021

Thanks @DrAlaafeef, you're seeing this because we modified the DynUNet public interface again, see #1596. We deleted the get_feature_maps method and returned a concatenated tensor containing both the output of the forward pass and the feature maps (if deep_supervision==True).

Would you be able to create an issue on the Tutorials repository? We're currently in the process of setting up our CI/CD to automatically run all of our tutorials, so we should avoid this sort of problem in the future.

@yiheng-wang-nv do you think you could take care of the Tutorials PR?

@rijobro
Copy link
Copy Markdown
Contributor

rijobro commented Feb 21, 2021

@DrAlaafeef Alternatively, you can checkout the 0.4.0 tag for both MONAI and the tutorials to ensure they are in sync with each other.

@Nic-Ma Nic-Ma deleted the 1390-enhance-dyunet-feature-map branch July 2, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sliding Window Inference giving error on 0.4.0

5 participants

@Nic-Ma @DrAlaafeef @rijobro @wyli @yiheng-wang-nv