adding .venv directory to ignores for flake8 and isort#1371
Merged
wyli merged 1 commit intoProject-MONAI:masterfrom Dec 16, 2020
charliebudd:1370-flake8-isort-ignore-update
Merged
adding .venv directory to ignores for flake8 and isort#1371wyli merged 1 commit intoProject-MONAI:masterfrom charliebudd:1370-flake8-isort-ignore-update
wyli merged 1 commit intoProject-MONAI:masterfrom
charliebudd:1370-flake8-isort-ignore-update
Conversation
Signed-off-by: charliebudd <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: charliebudd [email protected]
Fixes #1370 .
Description
Simply adds '.venv' to the list of ignores. It would be nice to use the VIRTUAL_ENV environment variable which I believe is accessable on linux and windows. However as we use a .cfg file I don't think it can be evaluated when the config is loaded.
I can use the environment variable by directly adding the ignore in runtests.sh however this then overwrites the ignores in the .cfg files
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.