Skip to content

1349 Align output data type with input in NormalizeIntensity#1352

Merged
wyli merged 6 commits intoProject-MONAI:masterfrom
Nic-Ma:1349-add-astype-normalizeintensity
Dec 11, 2020
Merged

1349 Align output data type with input in NormalizeIntensity#1352
wyli merged 6 commits intoProject-MONAI:masterfrom
Nic-Ma:1349-add-astype-normalizeintensity

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Dec 11, 2020

Fixes #1349 .

Description

This PR added support to align output data type with the input data in NormalizeIntensity transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Dec 11, 2020

/black

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Dec 11, 2020

/integration-test

@wyli wyli merged commit 4f880b4 into Project-MONAI:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

@ericspod ericspod Awaiting requested review from ericspod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing "astype(img.dtype)" in NormalizeIntensity

2 participants

@Nic-Ma @wyli