Skip to content

Update hausdorff metric and surface distance#1351

Merged
wyli merged 10 commits intoProject-MONAI:masterfrom
yiheng-wang-nv:1290-hausdorff-update
Dec 14, 2020
Merged

Update hausdorff metric and surface distance#1351
wyli merged 10 commits intoProject-MONAI:masterfrom
yiheng-wang-nv:1290-hausdorff-update

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Dec 11, 2020

Signed-off-by: yiheng-wang-nv [email protected]

Fixes #1290 .

Status

Work in progress

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: yiheng-wang-nv <[email protected]>
Signed-off-by: yiheng-wang-nv <[email protected]>
Signed-off-by: yiheng-wang-nv <[email protected]>
@yiheng-wang-nv
Copy link
Copy Markdown
Contributor Author

Will add the corresponding metric handlers later then a formal MR will be submitted

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Dec 14, 2020

Hi @yiheng-wang-nv ,

We plan to tag for MONAI v0.4 release soon, could you please help update this PR for review?

Thanks.

@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review December 14, 2020 13:03
@yiheng-wang-nv yiheng-wang-nv changed the title [WIP] Update hausdorff metric and surface distance Update hausdorff metric and surface distance Dec 14, 2020
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Dec 14, 2020

/integration-test /black

wyli added 2 commits December 14, 2020 18:50
Signed-off-by: Wenqi Li <[email protected]>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, all tests passed and changes tested locally

@wyli wyli merged commit dc5c3d4 into Project-MONAI:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update hausdorff_distance and surface_distance

3 participants