DynUNet Torchscript Support#1334
Merged
ericspod merged 7 commits intoProject-MONAI:masterfrom Dec 9, 2020
ericspod:dyunet_torchscript_fix
Merged
DynUNet Torchscript Support#1334ericspod merged 7 commits intoProject-MONAI:masterfrom ericspod:dyunet_torchscript_fix
ericspod merged 7 commits intoProject-MONAI:masterfrom
ericspod:dyunet_torchscript_fix
Conversation
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Contributor
|
Thanks @ericspod for your quick update on TorchScript support. Thanks. |
yiheng-wang-nv
approved these changes
Dec 9, 2020
Contributor
yiheng-wang-nv
left a comment
yiheng-wang-nv
left a comment
There was a problem hiding this comment.
Thanks @ericspod , I have checked the forward consistency for both train and val mode with our current version (I initialized these two versions of the networks with same weights), and the results are correct. I also run a training experiment under the Decathlon Dataset (task 4) and the performance is reasonable.
Member
Author
|
Thanks guys. There's some cleanup I need to do and run the tests but then the PR should be ready to go. |
Signed-off-by: Eric Kerfoot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1245 .
Description
Adds Torchscript support to the DynUNet class. This passes the unit tests but may require further inspection by someone more familiar with this network to ensure it functions as expected still.
Status
WIP
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.