Build docker images in self-hosted runners to offload dockerhub build#1270
Merged
wyli merged 3 commits intoProject-MONAI:masterfrom Nov 19, 2020
IsaacYangSLA:docker_build_in_self_hosted_runner
Merged
Build docker images in self-hosted runners to offload dockerhub build#1270wyli merged 3 commits intoProject-MONAI:masterfrom IsaacYangSLA:docker_build_in_self_hosted_runner
wyli merged 3 commits intoProject-MONAI:masterfrom
IsaacYangSLA:docker_build_in_self_hosted_runner
Conversation
Signed-off-by: Isaac Yang <[email protected]>
wyli
reviewed
Nov 19, 2020
Signed-off-by: Isaac Yang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Isaac Yang [email protected]
Fixes #1252
Description
The local docker build step (local_docker in deploy) builds the monai:latest from Dockerfile. This PR is to push that image to dockerhub. The build failure seemed related to the load in dockerhub. Moving the build process to our runners can reduce load on dockerhub and the build failure.
The local_docker step takes about 4min20sec~5min, and adding this docker push step does not occupy GPU resources.
** Requiring to add credential (DOCKER_PW of projectmonai) to repo's secrets.
** This PR does
docker logoutimmediately after docker push is done.Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.