Skip to content

Fix confusion matrix issue#1250

Merged
wyli merged 8 commits intoProject-MONAI:masterfrom
yiheng-wang-nv:1244-fix-confusion-matrix
Nov 18, 2020
Merged

Fix confusion matrix issue#1250
wyli merged 8 commits intoProject-MONAI:masterfrom
yiheng-wang-nv:1244-fix-confusion-matrix

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Nov 17, 2020

Signed-off-by: yiheng-wang-nv [email protected]

Fixes #1244 .

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review November 17, 2020 14:02
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks.

@Nic-Ma Nic-Ma requested review from ericspod and wyli November 17, 2020 14:10
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please see some comments inline

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.
Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 18, 2020

/integration-test

test

@wyli wyli merged commit 5ccfe7e into Project-MONAI:master Nov 18, 2020
@yiheng-wang-nv yiheng-wang-nv deleted the 1244-fix-confusion-matrix branch November 19, 2020 03:11
KumoLiu added a commit to KumoLiu/MONAI that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with compute_confusion_matrix metric

3 participants