1025 Add multi-threads support in ImageReaders#1030
Merged
Nic-Ma merged 9 commits intoProject-MONAI:masterfrom Sep 15, 2020
Nic-Ma:1025-add-multi-threads-imagereader
Merged
1025 Add multi-threads support in ImageReaders#1030Nic-Ma merged 9 commits intoProject-MONAI:masterfrom Nic-Ma:1025-add-multi-threads-imagereader
Nic-Ma merged 9 commits intoProject-MONAI:masterfrom
Nic-Ma:1025-add-multi-threads-imagereader
Conversation
merge master
merge master
merge master
1005 Support different margin for dims in CropForground (#1011)
merge master
merge master
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <[email protected]>
wyli
approved these changes
Sep 14, 2020
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks please see some minor comments inline. The APIs are experimental and look good for now, but probably they'll change when we deal with pathology images.
Contributor
Author
|
/black |
rijobro
pushed a commit
to rijobro/MONAI
that referenced
this pull request
Sep 15, 2020
* [DLMED] add multi-threads support for ImageReaders Signed-off-by: Nic Ma <[email protected]> * [DLMED] update according to comments Signed-off-by: Nic Ma <[email protected]> Signed-off-by: richard <[email protected]>
This was referenced Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1025 .
Description
This PR updated the
ImageReadersto make it more clear and compatible with multi-threads.Also added
kwargsto thereadfunction.Removed dependency between
readandget_datafunctions.Status
Ready
Types of changes
./runtests.sh --codeformat --coverage.make htmlcommand in thedocs/folder.