-
Notifications
You must be signed in to change notification settings - Fork 1.5k
overriding argument bug in spatial_resample #4938
Copy link
Copy link
Closed
Description
Describe the bug
the align_corners default value is False in SpatialResample.__call__
MONAI/monai/transforms/spatial/array.py
Line 198 in 009af55
| align_corners: Optional[bool] = False, |
this by default makes
self.align_corners not in use, because:MONAI/monai/transforms/spatial/array.py
Line 239 in 009af55
| align_corners = self.align_corners if align_corners is None else align_corners |
it easily causes confusions and hides some bugs.
expected:
align_corners=None in SpatialResample.__call__
example to show the errors:
import torch
from monai.transforms import SpatialResample
img = torch.arange(12).reshape((1, 2, 2, 3))
xform = SpatialResample(mode=0, padding_mode="reflect", align_corners=True)
dst_affine = torch.tensor([[1.0, 0.0, 0.0, 0.0], [0.0, -1.0, 0.0, 1.0], [0.0, 0.0, 1.0, 0.0], [0.0, 0.0, 0.0, 1.0]])
print(xform(img, dst_affine=dst_affine))Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels