Skip to content

UnetResBlock may create unused parameters if downsampling not used #4314

@ahatamiz

Description

@ahatamiz

Describe the bug
In UnetResBlock, conv and norm layers are created even if downsample is not used. This can lead to having unused parameters, hence creating issues with DDP and other procedures.

The better solution is to make conv and norm layer creation conditional on downsample.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions