-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update engines according to discussion #4148
Copy link
Copy link
Closed
Labels
enhancementNew feature or requestNew feature or request
Milestone
Description
Is your feature request related to a problem? Please describe.
According to the discussion in #4132 , would be nice to update:
- Still defining
_iteration()as a regular method, but unify all theself.XXXandengine.XXXtoengine.XXX. Because (1) as you said users can easily copy-paste our code, (2) maybe someone will override the enginerunlogic someday and pass other engine as parameter instead ofself: https://github.com/pytorch/ignite/blob/master/ignite/engine/engine.py#L859. - Check all the
engine: Enginefunctions, if having MONAI specific logic, change the typehint toWorkflow.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request