-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Issues with compute_confusion_matrix metric #1244
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
There are 2 minor issues in compute_confusion_matrix metric:
- If reduction mode is
SUMBATCH, should not do SUM onnot_nans, otherwise we don't know which class is nan when computing the final result. - If
compute_sampleis False, should return the confusion matrix elements of current batch directly, then compute the final metric value for the whole epoch. Current implementation computes metric for every batch, if batch size changed, the metric value will be different.
So in summary, should have 2 modes:
(1) Compute metric for every sample image first, then average or sum the whole epoch to get the final result.
(2) Keep the confusion matrix elements of every image, then average or sum the whole epoch, then compute metric.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working