Skip to content

Update com.apple.iMovieApp.plist #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apizz merged 2 commits into from
Feb 24, 2019
Merged

Update com.apple.iMovieApp.plist #40

apizz merged 2 commits into from
Feb 24, 2019

Conversation

@wegotoeleven
Copy link
Contributor

@wegotoeleven wegotoeleven commented Feb 8, 2019

Replaced LKWhatsNewDisplayedForAppVersion and LKWelcomeDisplayedForAppVersion with dictionaries, hardcoded to versions.

@wegotoeleven
Update com.apple.iMovieApp.plist
fc6825d 
Replaced LKWhatsNewDisplayedForAppVersion and LKWelcomeDisplayedForAppVersion with dictionaries, hardcoded to versions.
@apizz
Copy link
Collaborator

apizz commented Feb 8, 2019

@wegotoeleven so you can actually use {{key}} and {{value}} for the pfm_name in both dictionaries and it will allow you to supply both the iMovie version number as well as it's boolean value 😀 No version hardcoding needed!

More details here: https://github.com/erikberglund/ProfileManifests/wiki/User-Provided-Key-Names

@apizz
Copy link
Collaborator

apizz commented Feb 8, 2019

Here's my 2 cents:

<dict>
	<key>pfm_name</key>
	<string>LKWelcomeDisplayedForAppVersion</string>
	<key>pfm_type</key>
	<string>dictionary</string>
	<key>pfm_title</key>
	<string>Welcome displayed</string>
	<key>pfm_description</key>
	<string>Versions of iMovie to suppress the Welcome screen.</string>
	<key>pfm_description_reference</key>
	<string>Correct value is the whole version number, i.e 10.1.10. Can specify multiple versions if required.</string>
	<key>pfm_subkeys</key>
	<array>
		<dict>
			<key>pfm_description</key>
			<string></string>
			<key>pfm_name</key>
			<string>{{key}}</string>
			<key>pfm_title</key>
			<string>iMovie Version</string>
			<key>pfm_type</key>
			<string>string</string>
			<key>pfm_value_placeholder</key>
			<string>10.1.9</string>
		</dict>
		<dict>
			<key>pfm_default</key>
			<true/>
			<key>pfm_description</key>
			<string></string>
			<key>pfm_name</key>
			<string>{{value}}</string>
			<key>pfm_title</key>
			<string>Suppressed</string>
			<key>pfm_type</key>
			<string>boolean</string>
		</dict>
	</array>
</dict>
<dict>
	<key>pfm_name</key>
	<string>LKWhatsNewDisplayedForAppVersion</string>
	<key>pfm_type</key>
	<string>dictionary</string>
	<key>pfm_title</key>
	<string>Whats New displayed</string>
	<key>pfm_description</key>
	<string>Versions of iMovie to suppress the Whats New screen.</string>
	<key>pfm_description_reference</key>
	<string>Correct value is the whole version number, i.e 10.1.10. Can specify multiple versions if required.</string>
	<key>pfm_subkeys</key>
	<array>
		<dict>
			<key>pfm_description</key>
			<string></string>
			<key>pfm_name</key>
			<string>{{key}}</string>
			<key>pfm_title</key>
			<string>iMovie Version</string>
			<key>pfm_type</key>
			<string>string</string>
			<key>pfm_value_placeholder</key>
			<string>10.1.9</string>
		</dict>
		<dict>
			<key>pfm_default</key>
			<true/>
			<key>pfm_description</key>
			<string></string>
			<key>pfm_name</key>
			<string>{{value}}</string>
			<key>pfm_title</key>
			<string>Suppressed</string>
			<key>pfm_type</key>
			<string>boolean</string>
		</dict>
	</array>
</dict>

@apizz apizz self-assigned this Feb 8, 2019
apizz
apizz approved these changes Feb 8, 2019
View reviewed changes
Copy link
Collaborator

@apizz apizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good. Will complete PR soon.

@apizz apizz added the 🛠️ update manifest Update existing manifest label Feb 14, 2019
@apizz apizz merged commit ade1056 into ProfileManifests:master Feb 24, 2019
apizz added a commit that referenced this pull request Feb 24, 2019
@apizz
Update indexes for icons and manifests
838a509 
Per #53, #49, #48, #47, #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apizz apizz apizz approved these changes

Assignees

@apizz apizz

Labels

🛠️ update manifest Update existing manifest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wegotoeleven @apizz