Skip to content

Create com.apple.iMovieApp #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apizz merged 3 commits into from
Jan 31, 2019
Merged

Create com.apple.iMovieApp #21

apizz merged 3 commits into from
Jan 31, 2019

Conversation

@wegotoeleven
Copy link
Contributor

@wegotoeleven wegotoeleven commented Jan 7, 2019

Added 3 initial keys for first run screen suppression, for iMovie

@wegotoeleven
Create com.apple.iMovieApp
6e8574b 
Added 3 initial keys for first run screen suppression.
@apizz
Copy link
Collaborator

apizz commented Jan 28, 2019

@wegotoeleven if you can get the formatting aligned, I'll get this merged.

@wegotoeleven
Formatting.
c6e12a5 
As requested :)
@wegotoeleven
Copy link
Contributor Author

wegotoeleven commented Jan 29, 2019

Formatting should be sorted now :) Sorry bou' dat!

@apizz apizz self-assigned this Jan 29, 2019
apizz
apizz requested changes Jan 29, 2019
View reviewed changes
Copy link
Collaborator

@apizz apizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wegotoeleven there's still some formatting that needs fixing. Blank lines between dictionaries. And at the end the closing dict and array tags aren't aligned.

@wegotoeleven
Formatting
ad31828 
Copying and pasting from my editor *hopefully* has fixed these!
@wegotoeleven
Copy link
Contributor Author

wegotoeleven commented Jan 29, 2019

Hopefully this is sorted!

wegotoeleven
wegotoeleven commented Jan 29, 2019
View reviewed changes
Copy link
Contributor Author

@wegotoeleven wegotoeleven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be sorted.

@apizz apizz merged commit 0477a96 into ProfileManifests:master Jan 31, 2019
@apizz
Copy link
Collaborator

apizz commented Jan 31, 2019

@wegotoeleven I was just looking at this more closely, and on a test machine that has 10.1.9 installed, I'm seeing both LKWelcomeDisplayedForAppVersion and LKWhatsNewDisplayedForAppVersion are both dictionaries - not arrays - and the iMovie version is the key with a boolean value. What I'm seeing below:

<key>LKWelcomeDisplayedForAppVersion</key>
<dict>
	<key>10.1.9</key>
	<true/>
</dict>
<key>LKWhatsNewDisplayedForAppVersion</key>
<dict>
	<key>10.1.9</key>
	<true/>
</dict>

Just want to make sure I'm not missing something. If this needs updating, I have a manifest update ready to go.

@wegotoeleven
Copy link
Contributor Author

wegotoeleven commented Feb 8, 2019

Yep, I can confirm. Making changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apizz apizz apizz approved these changes

Assignees

@apizz apizz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wegotoeleven @apizz