Skip to content

Update ProfileCreator #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinmcox merged 60 commits into from
Nov 20, 2024
Merged

Update ProfileCreator #261

kevinmcox merged 60 commits into from
Nov 20, 2024

Conversation

@WillYu91
Copy link
Contributor

@WillYu91 WillYu91 commented Nov 26, 2023 •
edited
Loading

  • Removed Sparkle, will use MAS for updates for now, will probably re-introduce it back in at a later time for Non-MAS distributions (Need to use the new swift package workflow)
  • Moved ProfilePayloads and ProfileManifests to submodules
  • Moved Highligtr framework to submodule to reduce code bloat from 3rd party framework
  • Implemented profile settings preview
  • Fixed toolbar icons to no longer use custom buttons and mouse area listeners, this was breaking per major OS version and was more trouble than it was worth compared to just using built in system APIs
  • Squashed almost all warnings -> down to ~3 warnings
  • Warnings that we can't squash are due to feature deprecations of the OS that we can't avoid, and swift does not provide a way to silence one particular instance of a warning (the others can be squashed by moving from using the SecCertificate API -> swift x509 API
  • Set up XCode cloud building for CI -> Not sure how this will work in the main repo, I think it only works in mine
  • System extension + Kernel extension policy support for editing bundles in the UI directly
  • Fix issue with Microsoft opentype fonts
  • Various UI fixes and alignments with text/checkboxes

WillYu91 added 30 commits October 10, 2022 18:44
@WillYu91
Fix importing issue with system extensions where the user cannot spec…
861d5b1 
…ify bundle ID
@WillYu91
Use new toolbar style for Ventura
8e79920 
Revert change
@WillYu91
Merge branch 'fix/toolbaritems_ventura' into fix/system_extension_pay…
2021a54 
…loads
@WillYu91
Fix array inputs
acc0e23
@WillYu91
Merge pull request #1 from WillYu91/fix/system_extension_payloads
a55ea4e 
Fix/system extension payloads
@WillYu91
Revert uneeded change, add comment
5da904d
@WillYu91
Merge pull request #2 from WillYu91/fix/system_extension_payloads
579ffeb 
Revert uneeded change, add comment
@WillYu91
Fix microsoft opentype fonts
869b8d2
@WillYu91
Add missing include and formatting
9f63724
@WillYu91
Add start up guide
44713c3
@WillYu91
Fix casing
dcec8bd
@WillYu91
Xcode version
6a8d9cf
@WillYu91
Add note about default derived data
73cbed0
@WillYu91
Merge pull request #3 from WillYu91/fix/microsoft_font_types
ded3c52 
Fix/microsoft font types
@WillYu91
Merge pull request #4 from WillYu91/enh/getting_started_doc
1c4da6e 
Enh/getting started doc
@WillYu91
Squash a bunch of warnings
59352a5
@WillYu91
Squash a bunch of warnings 2
0b86724
@WillYu91
Merge pull request #5 from WillYu91/fix/squash_warnings
4d08d5b 
Squash a bunch of warnings
@WillYu91
Merge branch 'ProfileCreator:master' into master
c178f67
@WillYu91
Use secure timestamp
1b4c772
@WillYu91
Create target for app store distribution
57ac735
@WillYu91
Fix button alignment sonoma
b9d2aa8
@WillYu91
Merge pull request #6 from WillYu91/fix/alignment_sonoma
b8afc64 
Fix toolbar button alignments for macOS Sonoma
@WillYu91
Remove Sparkle Framework
7f47564
@WillYu91
Remove Sparkle Framework actually
f5e966d
@WillYu91
Fix schemes
3c4d698
@WillYu91
Update README.md
fb71f55
@WillYu91
Merge pull request #7 from WillYu91/WillYu91-patch-1
0eb6ea1 
Update README.md
@WillYu91
Saving work, refactoring NSToolbarItems usage
0f5fd0e
@WillYu91
Redo NSToolbar usage, modernize and fix alignment issues. Move to use…
146615a 
… SF Symbols as much as possible
WillYu91
WillYu91 commented Nov 26, 2023
View reviewed changes
.gitmodules
@@ -0,0 +1,6 @@
[submodule "ProfileCreator/ProfilePayloads"]
path = ProfileCreator/ProfilePayloads
url = https://github.com/WillYu91/ProfilePayloads
Copy link
Contributor Author

@WillYu91 WillYu91 Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProfilePayloads repo has fixes that needs to be updated, waiting on someone to push fixes in before I change this

@kevinmcox
Copy link
Member

kevinmcox commented Mar 3, 2024

Will, thank you very much for all your work and submitting this here.

To be honest, with 886 files changes there is no way I'd be able to review, let alone likely understand, all the changes in this PR.

That said, I was able to successfully build the app following the instructions in the ReadMe (after opening the project in Xcode and removing the signing certificate I obviously don't have access to). It opened and ran fine, and the crashing issue with the SSO Extension is indeed fixed.

There are a few things I noticed that I think we need to get everyone in agreement on so we can move forward:

• The Bundle ID is changed. I personally think we should stick with the existing com.github.ProfileCreator
• Copyright. Would it make sense to have the copyright be © 2024 The ProfileCreator Project (or something similar)? This would mirror other open source projects like Munki.

Once we agree on those and any other issues I think it is time to take a leap of faith, merge this PR and cut a new release.

@WillYu91
Copy link
Contributor Author

WillYu91 commented Mar 3, 2024

Yes those are all reasonable changes to ask for I'll go ahead and make them, thank you!

@SandiyosDev
Copy link

SandiyosDev commented Apr 2, 2024

I'm on board with this, dropping my support!

@WillYu91
Copy link
Contributor Author

WillYu91 commented Apr 21, 2024

@kevinmcox I've updated the bundle ID and copyright

kevinmcox
kevinmcox approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@kevinmcox kevinmcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all this work!

@WillYu91
Copy link
Contributor Author

WillYu91 commented Jul 6, 2024

Hey @kevinmcox I don't have merge permissions, someone with permissions will need to merge this PR

image

@kevinmcox
Copy link
Member

kevinmcox commented Jul 7, 2024

Thanks for the reminder @WillYu91. One thing I forgot to ask about is the Sparkle feed, I think we should keep that in the app and I'm not sure where the current commits stand.

@WillYu91
Copy link
Contributor Author

WillYu91 commented Aug 3, 2024

@kevinmcox done here 022f420

@kevinmcox
Copy link
Member

kevinmcox commented Sep 2, 2024

I left a comment on that last commit, the URL needs to be updated.

@kevinmcox kevinmcox merged commit 1b060dd into ProfileCreator:master Nov 20, 2024
@kevinmcox kevinmcox mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmcox kevinmcox kevinmcox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WillYu91 @kevinmcox @SandiyosDev