Line Highlight: Account for offset when clamping ranges#3518
Line Highlight: Account for offset when clamping ranges#3518RunDevelopment merged 1 commit intoPrismJS:masterfrom
Conversation
JaKXz
left a comment
JaKXz
left a comment
There was a problem hiding this comment.
I see that the line-highlight plugin does not have any tests. I think adding one would be good as part of this PR, if possible
|
Alright, so #3524 is not gonna happen until #3408 which require v2. So either we change our stance on #3408 or we merge this PR without tests and add them in later. I don't want to have a bunch of long expected HTML in the test files, so I don't want to do these tests without snapshots. Also, I'll likely have a bit of time on my hands next week, so I could start work with v2. So merging this PR now, making the last v1 release with weekend, and then starting with v2 would be my preferred timeline. Thoughts? @JaKXz @mAAdhaTTah @Golmote @LeaVerou |
That seems fine. Let's go w/ it. |
JaKXz
left a comment
JaKXz
left a comment
There was a problem hiding this comment.
Agreed with @mAAdhaTTah 👍🏽
3 participants
This fixes #3517.
This was caused by #3475. I failed to take the offset into account when giving my suggestion.
Screenshot of the example in #3517 working.