JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +51 B (+3.5%).

Generated by 🚫 dangerJS against 0240cd6

Thank you for the PR @lijyze!

Unfortunately, I do not understand the problem you fixed. Could you please explain it in more detail? Maybe even provide some screenshots?

@RunDevelopment Sorry for bad explanation.

Let's say, if my code looks like this, it has only 3 lines of code.

Now I want highlight some lines of it.

• If the end line of range exceed max line numbers of code, such as data-line="2-10"
  • Without class="line-numbers":
    
  • And with class="line-numbers":
    

I think this make sense, it means highlight from the start of the range to the end of the code.
But if the section is exceeded by a line rather than a range, things comes a little weird.

• Code section exceed by a line, such as data-line="4"
  • Without class="line-numbers":
    
    This could be hidden as required.
  • With class="line-numbers":
    
    It display incorrectly in some ways, and there seems no way to post-process it.

What have I done is ignore lines that exceed line numbers of code section when class="line-number" is present.

Thank you for reading this, I wish you a good day!

Thank you for the detailed explanation!

Instead of working around the different behavior of with and without class="line-number", why don't we fix the underlying problem? The real problem is that the range is invalid. If the start and end of the range were inside the code block, we wouldn't have this issue in the first place.

So we could count the number of lines (once) and then do end = Math.min(numberOfLines, end). What do you think about this approach?

Similarly, we could also ignore (= not display) any ranges or single-lines if their start is greater than the number of lines.

Yeah! Your solution is much more elegant.
Thanks you for giving pointer!!! I have done with code!

Thank you for contributing @lijyze!