Add support for Gradle#3443
Conversation
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +721 B (+29.9%). Details
|
There was a problem hiding this comment.
Thank you for the PR @zeabdelkhalek!
It seems like you based this language of Groovy. That's obviously a good choice, but please adjust the tests. It seems like most of them have just been copied over, so please adjust them. Btw, to update tests quickly, just run npm run test:languages -- --update.
Also, code style. Please copy the code style from languages. npm run lint:fix is probably a good start.
|
@RunDevelopment I have made the necessary changes, could you check again please? |
|
@RunDevelopment fixed, can you check again? |
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
I found a few minor things, but otherwise it's good to go.
Also, please run npm run build to update the minified files.
|
@RunDevelopment can you check again? |
|
Thank you for contributing @zeabdelkhalek! |
3 participants
This resolves #3353