Drop support for NodeJS 10.x in development#3408
Closed
RunDevelopment wants to merge 2 commits intoPrismJS:masterfrom
Closed
Drop support for NodeJS 10.x in development#3408RunDevelopment wants to merge 2 commits intoPrismJS:masterfrom
RunDevelopment wants to merge 2 commits intoPrismJS:masterfrom
Conversation
Member
|
I feel like I said this when we dropped Node 8 support, but technically this is a breaking change. |
Member
Author
|
Then let's wait til v2. Honestly, I'm currently trying to get #3280 to prepare for a new release. We might as well make it the last v1 release. |
Collaborator
|
On a related /tangential/hopefully not too controversial note, can I bring up the possibility of moving to ESM for v2.0 as well? We may already have an issue for this but I'm not sure 😅 |
Member
Author
Yup, we do :) #2715. Moving to ESM is very much planned for v2. |
This was referenced Aug 18, 2022
Collaborator
|
@RunDevelopment is this already in the v2 branch? If not you could change the base branch to |
Member
Author
|
Yes, this is already implemented in v2. I'll close this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeJS 10.x lost support on 30 Apr 2021.
This PR removes NodeJS 10.x from your CI and changes the development requirements in the readme.