Skip to content

EditorConfig support#2471

Merged
RunDevelopment merged 4 commits into
PrismJS:masterfrom
osipxd:feature/editorconfig
Jul 10, 2020
Merged

EditorConfig support#2471
RunDevelopment merged 4 commits into
PrismJS:masterfrom
osipxd:feature/editorconfig

Conversation

@osipxd

@osipxd osipxd commented Jul 10, 2020

Copy link
Copy Markdown
Contributor

Tried to add EditorConfig support. Please check if I've done it right.
image

Closes #2462

@RunDevelopment RunDevelopment left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this language definition @osipxd!

I have a few minor suggestions but overall, it looks really good. Great work!

Comment thread components/prism-editorconfig.js Outdated
Comment thread components/prism-editorconfig.js
Comment thread components/prism-editorconfig.js Outdated
Comment thread components/prism-editorconfig.js Outdated
Comment thread components/prism-editorconfig.js Outdated
@osipxd
osipxd requested a review from RunDevelopment July 10, 2020 21:47
@RunDevelopment
RunDevelopment merged commit ed8fff9 into PrismJS:master Jul 10, 2020
@RunDevelopment

Copy link
Copy Markdown
Member

Thank you for contributing @osipxd!

@osipxd
osipxd deleted the feature/editorconfig branch July 13, 2020 11:01
quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EditorConfig syntax highlight support

2 participants