Skip to content

Bash: Add PHP dependency manager composer as a command#2298

Merged
RunDevelopment merged 2 commits into
PrismJS:masterfrom
Ayesh:feature/bash-composer
Apr 9, 2020
Merged

Bash: Add PHP dependency manager composer as a command#2298
RunDevelopment merged 2 commits into
PrismJS:masterfrom
Ayesh:feature/bash-composer

Conversation

@Ayesh

@Ayesh Ayesh commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

Hi there,
composer is PHP's dependency manager, and I would like to propose that we add it as a command to bash language support. I see that npm is already in the list, which has equal grounds as composer.

Thank you.

@RunDevelopment RunDevelopment left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add "composer" to the function test.

@RunDevelopment
RunDevelopment merged commit 044dd27 into PrismJS:master Apr 9, 2020
@RunDevelopment

Copy link
Copy Markdown
Member

Thank you for contributing @Ayesh!

@Ayesh

Ayesh commented Apr 9, 2020

Copy link
Copy Markdown
Contributor Author

Thank you @RunDevelopment. I'm sorry I forgot to update the tests.

@Ayesh

Ayesh commented Apr 9, 2020

Copy link
Copy Markdown
Contributor Author

Awesome, this is merged, thank you 🙏.

quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
This adds PHP's dependency manager `composer` to the list of commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants