Skip to content

pacaligo: adding support for pascaligo, http://ligolang.org#1947

Merged
RunDevelopment merged 6 commits into
PrismJS:masterfrom
DefinitelyNotAGoat:master
Jul 11, 2019

Conversation

@DefinitelyNotAGoat

@DefinitelyNotAGoat DefinitelyNotAGoat commented Jun 21, 2019

Copy link
Copy Markdown
Contributor

Summary
This PR adds the language definition for pascaligo, a layer 2 smart contract language for the Tezos blockchain.

http://ligolang.org

@RunDevelopment

Copy link
Copy Markdown
Member

@DefinitelyNotAGoat Thank you for making this PR.

However, I have a little question: Isn't this language definition basically the combination of PascalLIGO and CameLIGO which are two languages with different syntax?

And a small note: the tests failed because components/prism-ligo.min.js isn't up to date. Rebuilding Prism should fix this issue.

I'll do the full review soon.

@DefinitelyNotAGoat

Copy link
Copy Markdown
Contributor Author

Thanks @RunDevelopment! So this is actually the pascaligo version so I will edit to make sure that's noted, rebuild and push.

@DefinitelyNotAGoat DefinitelyNotAGoat changed the title ligo: adding support for ligo, http://ligolang.org pacaligo: adding support for pascaligo, http://ligolang.org Jun 25, 2019
@DefinitelyNotAGoat

Copy link
Copy Markdown
Contributor Author

Rebuilt, and pushed name changes to accurately reflect pascaligo.

@RunDevelopment RunDevelopment left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DefinitelyNotAGoat Thank you for the clarification!

I left you a few comments.
Also could you please add an example page showing off the main features of the language? (Something like this)

Apart from these two things, really solid work! I'll be looking forward to the final result!

Comment thread components.json Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread tests/languages/pascaligo/builtin_feature.test Outdated
Comment thread tests/languages/pascaligo/function_feature.test Outdated
Comment thread components/prism-pascaligo.js Outdated
Merge branch 'master' into master.
@DefinitelyNotAGoat

Copy link
Copy Markdown
Contributor Author

@RunDevelopment thanks for the review.

I added some new changes to correct the issues. Let me know if you need anything else!

Comment thread examples/prism-pascaligo.html Outdated
Comment thread tests/languages/pascaligo/boolean_feature.test Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Comment thread components/prism-pascaligo.js Outdated
Requests include regex improvements,
and formatting.

Merge branch 'master' into master.
@DefinitelyNotAGoat

Copy link
Copy Markdown
Contributor Author

Thanks for the tips @RunDevelopment! I re-pushed new changes to reflect the change requests.

@RunDevelopment

Copy link
Copy Markdown
Member

Nice!
Could please also take a look at the PR I send you?

@RunDevelopment

Copy link
Copy Markdown
Member

I think this is ready.

Thank you for contributing @DefinitelyNotAGoat!

@RunDevelopment
RunDevelopment merged commit 858201c into PrismJS:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants