Skip to content

Markdown: Added support for auto-loading code block languages#1898

Merged
RunDevelopment merged 7 commits into
PrismJS:masterfrom
RunDevelopment:markdown-autoloader
Jul 22, 2019
Merged

Markdown: Added support for auto-loading code block languages#1898
RunDevelopment merged 7 commits into
PrismJS:masterfrom
RunDevelopment:markdown-autoloader

Conversation

@RunDevelopment

Copy link
Copy Markdown
Member

This resolves #1644.

Autoloader now also exposes a loadLanguages function which, in contrast to the private loadLanguages, guarantees that callbacks are executed asynchronously.

@ExE-Boss ExE-Boss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

Comment thread plugins/autoloader/prism-autoloader.js Outdated
@mAAdhaTTah

Copy link
Copy Markdown
Member

Thought: are we better off adding extra code so the public API so it's always async or fix the internal implementation to be always async?

@RunDevelopment
RunDevelopment merged commit 05823e8 into PrismJS:master Jul 22, 2019
@RunDevelopment
RunDevelopment deleted the markdown-autoloader branch July 22, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown should auto load languages

3 participants