Doc comment highlighting#1541
Merged
Merged
Conversation
Added test.
mAAdhaTTah
reviewed
Dec 1, 2018
mAAdhaTTah
reviewed
Dec 1, 2018
mAAdhaTTah
reviewed
Dec 1, 2018
Member
|
Overall, this looks good. Obvs there's some conflicts, but I think they're just files to regen. Regex's seem fine, but I'm not really qualified to review them. That said, I think we're comfortable merging now even if I can't and making changes later if we have improvements. |
Member
Author
|
It's been a while since I last looked at this. |
Member
Author
|
Alright, I think this is ready now. @mAAdhaTTah You might want to take a look at the changes I made. |
This was referenced Oct 26, 2019
This comment has been minimized.
This comment has been minimized.
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #1475.
It adds support for JavaDoc (Java), PHPDoc (PHP), and JSDoc (JS, JSX, N4JS, TS, TSX).
This will also affect languages which include any of the above languages.
Notes:
Examples
TypeScript
JavaScript
Java
PHP